IssueUserCIDUnused

From BRIstuff.org

Revision as of 13:42, 19 November 2007; Tzafrir (Talk | contribs)
(diff) ←Older revision | Current revision | Newer revision→ (diff)
Jump to: navigation, search

This is basically a matter of useless code and code quality.

BRIstuff's patch includes an extra configuration value in zapata.conf: "pritrustusercid". It seems to eventually set a boolean value called "usercid" in struct zt_pri for a span.

  • This value is an int, rather than a bit flag, even though it is a boolean.
  • The config item is "pritrustusercid", but the field name is "usercid" - less intuitive.
  • usercid is explicitly initialized to 0 in zt_conf.pri . This is not necessary.
  • And then again, that value is never used.

Issues

Retrieved from "http://bristuff.org/index.php/IssueUserCIDUnused"