IssueNoCIDInit

The patched chan_zap.c had two left-over globals, nocid and withheldcid . Those were never used .
zt_conf.pri.nocid and zt_conf.pri.withheldcid were not properly initialized.
The length of those fields was 256 characters. But their only usage was as a callerID field. And the callerID's length is AST_MAX_EXTENSION .
In various places in the code strncpy is used where ast_copy_string should be.
In various other places ast_copy_string is used, but still with an offset of 1 character. This is unnecessary.

As a note, a grep for '256' in the patched chan_zap will show various magic values. All of those come from the bristuff patch.